RHIDP-4807: Third-party plugin installation in RHDH #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmanwani-rh
added
do-not-merge/work-in-progress
do-no-merge/review-in-progress 👀
and removed
do-not-merge/work-in-progress
labels
Collaborator
|
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-733/ @ 12/13/24 14:34:42 |
hmanwani-rh
force-pushed
the
RHIDP-4807-main
branch
from
43e7d33 to
5989fe4
Compare
Member
Author
|
@kadel Could you please review this PR and share your comments? |
kadel
requested changes
Nov 27, 2024
assemblies/dynamic-plugins/assembly-third-party-plugins-installation.adoc
Outdated
Show resolved
Hide resolved
assemblies/dynamic-plugins/assembly-third-party-plugins-installation.adoc
Outdated
Show resolved
Hide resolved
assemblies/dynamic-plugins/assembly-third-party-plugins-installation.adoc
Outdated
Show resolved
Hide resolved
assemblies/dynamic-plugins/assembly-third-party-plugins-installation.adoc
Outdated
Show resolved
Hide resolved
assemblies/dynamic-plugins/assembly-third-party-plugins-installation.adoc
Outdated
Show resolved
Hide resolved
modules/dynamic-plugins/proc-install-third-party-plugins-rhdh.adoc
Outdated
Show resolved
Hide resolved
modules/dynamic-plugins/proc-install-third-party-plugins-rhdh.adoc
Outdated
Show resolved
Hide resolved
modules/dynamic-plugins/proc-install-third-party-plugins-rhdh.adoc
Outdated
Show resolved
Hide resolved
modules/dynamic-plugins/proc-install-third-party-plugins-rhdh.adoc
Outdated
Show resolved
Hide resolved
modules/dynamic-plugins/proc-package-third-party-dynamic-plugin.adoc
Outdated
Show resolved
Hide resolved
gashcrumb
reviewed
Nov 27, 2024
assemblies/dynamic-plugins/assembly-third-party-plugins-installation.adoc
Outdated
Show resolved
Hide resolved
gashcrumb
reviewed
Nov 27, 2024
assemblies/dynamic-plugins/assembly-third-party-plugins-installation.adoc
Outdated
Show resolved
Hide resolved
gashcrumb
reviewed
Nov 27, 2024
assemblies/dynamic-plugins/assembly-third-party-plugins-installation.adoc
Outdated
Show resolved
Hide resolved
gashcrumb
reviewed
Nov 27, 2024
assemblies/dynamic-plugins/assembly-third-party-plugins-installation.adoc
Outdated
Show resolved
Hide resolved
themr0c
added
QE review needed 🔧
Technical review needed 🔩
hmanwani-rh
force-pushed
the
RHIDP-4807-main
branch
from
bc325b7 to
cf82276
Compare
kadel
reviewed
Dec 4, 2024
modules/dynamic-plugins/ref-example-third-party-plugin-installation.adoc
Outdated
Show resolved
Hide resolved
kadel
reviewed
Dec 4, 2024
modules/dynamic-plugins/ref-example-third-party-plugin-installation.adoc
Show resolved
Hide resolved
kadel
reviewed
Dec 4, 2024
modules/dynamic-plugins/proc-export-third-party-plugins-rhdh.adoc
Outdated
Show resolved
Hide resolved
kadel
reviewed
Dec 4, 2024
modules/dynamic-plugins/proc-export-third-party-plugins-rhdh.adoc
Outdated
Show resolved
Hide resolved
hmanwani-rh
force-pushed
the
RHIDP-4807-main
branch
from
ab4f65b to
076cd9e
Compare
kadel
approved these changes
Dec 13, 2024
themr0c
reviewed
Dec 13, 2024
modules/dynamic-plugins/proc-export-third-party-plugins-rhdh.adoc
Outdated
Show resolved
Hide resolved
themr0c
reviewed
Dec 13, 2024
themr0c
reviewed
Dec 13, 2024
themr0c
reviewed
Dec 13, 2024
themr0c
reviewed
Dec 13, 2024
themr0c
reviewed
Dec 13, 2024
themr0c
requested changes
Dec 13, 2024
Member
themr0c
left a comment
themr0c
left a comment
There was a problem hiding this comment.
Consider using [source,terminal] rather than [source,bash] to denote a terminal command. See https://redhat-documentation.github.io/supplementary-style-guide/#code-example-syntax-highlighting
modules/dynamic-plugins/proc-export-third-party-plugins-rhdh.adoc
Outdated
Show resolved
Hide resolved
modules/dynamic-plugins/ref-example-third-party-plugin-installation.adoc
Outdated
Show resolved
Hide resolved
modules/dynamic-plugins/ref-example-third-party-plugin-installation.adoc
Outdated
Show resolved
Hide resolved
modules/dynamic-plugins/ref-example-third-party-plugin-installation.adoc
Outdated
Show resolved
Hide resolved
modules/dynamic-plugins/ref-example-third-party-plugin-installation.adoc
Outdated
Show resolved
Hide resolved
modules/dynamic-plugins/ref-example-third-party-plugin-installation.adoc
Outdated
Show resolved
Hide resolved
Member
Author
|
/cherry-pick release-1.4 |
Contributor
|
@hmanwani-rh: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Contributor
|
@hmanwani-rh: new pull request created: #793 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Gerry-Forde
pushed a commit
to Gerry-Forde/red-hat-developers-documentation-rhdh-v2
that referenced
this pull request
Dec 16, 2024
…#733) * RHIDP-4807: Third-party plugin installation in RHDH * fixed minor issues * Incorporated review suggestions * incorporated review suggestions * fixed links and added context to install plugin assembly * review suggestions incorporated * review suggestions incorporated * review suggestions incorporated * review suggestions incorporated * review suggestions incorporated
otikhomi
pushed a commit
to otikhomi/red-hat-developers-documentation-rhdh
that referenced
this pull request
Jan 20, 2025
…#733) * RHIDP-4807: Third-party plugin installation in RHDH * fixed minor issues * Incorporated review suggestions * incorporated review suggestions * fixed links and added context to install plugin assembly * review suggestions incorporated * review suggestions incorporated * review suggestions incorporated * review suggestions incorporated * review suggestions incorporated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s):
1.4
Add the relevant labels to the Pull Request.
Issue:
RHIDP-4807